Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for compatibility with Rotations.jl v1.1.0 #629

Closed
wants to merge 6 commits into from
Closed

Updates for compatibility with Rotations.jl v1.1.0 #629

wants to merge 6 commits into from

Conversation

ferrolho
Copy link
Member

@ferrolho ferrolho force-pushed the hf/compat-rotations branch from d00b603 to 198ac52 Compare November 30, 2021 23:08
@ferrolho ferrolho changed the title Renames UnitQuaternion to QuatRotation Updates for compatibility with Rotations.jl v1.1.0 Nov 30, 2021
@ferrolho ferrolho mentioned this pull request Dec 3, 2021
Merged
@ferrolho
Copy link
Member Author

ferrolho commented Dec 4, 2021 •
edited
Loading

Hi, Twan! :)

The CI errors for Julia 1.3 are due to incompatibilities during version resolving of the dependencies. I think this can be solved by bumping up a couple of the deps lagging behind.

As for the Documentation and Julia 1.5 CI errors, those are because this PR depends on rdeits/MeshCat.jl#210 being merged---as hinted by the error message LoadError: type QuatRotation has no field x. This error is only on the notebooks though, the rest of the RBD.jl tests are all passing on my machine.

@ferrolho ferrolho mentioned this pull request Dec 20, 2021
Merged
@ferrolho
Updates Manifest.toml and Project.toml of Jupyter notebooks
fedccbe 
Temporarily excludes notebook "6. Symbolics using SymPy" because of Quaternions.jl issue on handling symbols from SymPy.jl. (See JuliaGeometry/Quaternions.jl#8.)
@ferrolho ferrolho force-pushed the hf/compat-rotations branch from ffaa4db to 127e7e2 Compare January 14, 2022 14:40
@ferrolho
Reverts Manifest.toml of notebooks to the old manifest format
127e7e2 
The CI GitHub actions would have to be updated in order to support Julia 1.7 and the new manifest format.
@ferrolho
Copy link
Member Author

Okay, I have finally managed to get the CI checks for Julia 1.5 to pass. I think maybe we can drop the Julia 1.3 checks? Ideally though, we should remove both 1.3 and 1.5, and then add checks for Julia 1.6, since that is not the LTS release. (Unless there are other reasons for maintaining 1.3 and 1.5 that I am not aware of.)

@ferrolho
Copy link
Member Author

Oh, and there's also a slight problem with the Rotations.jl update. I wasn't able to get notebook 6 to work with the new version, as it complains that a Quaternion cannot be created from symbolic variables.

@ferrolho
Copy link
Member Author

@tkoolen, can you please have a look at this PR, and also at #622 and #616? It would be great if you could merge them and tag a new release. It has been a while since we have tagged a release...

@ferrolho ferrolho mentioned this pull request May 8, 2023
Merged
@ferrolho
Copy link
Member Author

I am going to close this as it has been superseded by #634.

@ferrolho ferrolho closed this May 30, 2023
@ferrolho ferrolho deleted the hf/compat-rotations branch November 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferrolho