Renames UnitQuaternion to QuatRotation
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Rotations.jl v1.1.0 (https://github.com/JuliaGeometry/Rotations.jl/releases/tag/v1.1.0).
|
Hi, Robin! Let me know if you are happy with these changes. I asked for advice regarding one of the changes here. I chose to change the code with minimal effort, but I guess the drawback is that we are again relying on the field names used in the internal structure of quaternions. |
rdeits
reviewed
Dec 3, 2021
|
Thank you, Robin! Any chance you can tag a new release to cover these changes? |
|
|
done! Sorry for the delay, we just had a baby :) |
That's amazing news, Robin! Congratulations!! 👶 Best of luck! And thank you for the new version release. 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Rotations.jl v1.1.0 (https://github.com/JuliaGeometry/Rotations.jl/releases/tag/v1.1.0).