Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand simultaneous XFB binding test #3476

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

lexaknyazev
Copy link
Member

When a bufferData call is rejected due to simultaneous bindings, the bound buffer size must not reset. The new test fails in Chromium, passes in WebKit and Firefox.

Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there an associated WebKit bug fix for this new test? I haven't run the new test yet but it looks like on all platforms which use ANGLE this error should be caught:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/validationES2.cpp;l=3570?q=validationES2.cpp

@lexaknyazev
Copy link
Member Author

WebKit was failing the test even before this PR; fixed here: https://commits.webkit.org/253210@main.

Chromium resets the buffer size before calling into ANGLE:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc;l=2171

@kenrussell
Copy link
Member

Upon further review, I see the Chromium-side cache that's being updated incorrectly during this test and am fixing it; would still appreciate pointers to any WebKit bug fixes. Thanks.

@kdashg kdashg merged commit 4d21139 into KhronosGroup:main Sep 8, 2022
@lexaknyazev lexaknyazev deleted the tf branch September 8, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants