Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak state between adjacent XFB tests #3675

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

lexaknyazev
Copy link
Member

Unbind the buffer from the COPY_WRITE_BUFFER target so that it is bound only as XFB for the next test.

Unbind the buffer from the COPY_WRITE_BUFFER target
so that it is bound only as XFB for the next test.
@lexaknyazev
Copy link
Member Author

@kenrussell This is just a side-effect cleanup so that the actual issue (tested by the code after the new line) is better represented. Passes in Firefox and WebKit, fails in Chromium just like #3476.

Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this test bug. Looks good.

@kenrussell kenrussell merged commit d47f2cc into KhronosGroup:main Jul 26, 2024
2 checks passed
@lexaknyazev lexaknyazev deleted the fix-xfb-test branch July 26, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants