Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak state between adjacent XFB tests #3675

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Do not leak state between adjacent XFB tests #3675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/tests/conformance2/transform_feedback/simultaneous_binding.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "copyBufferSubData with double bound buffer");
gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 1);
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "copyBufferSubData with double bound buffer");
gl.bindBuffer(gl.COPY_WRITE_BUFFER, null);

debug("<hr/>Test that rejected operations do not change the bound buffer size");

Expand All @@ -312,7 +313,7 @@

gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK, null);
gl.bufferSubData(gl.ARRAY_BUFFER, 0, new Uint8Array(16));
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "bufferSubData should succeed");
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "bufferSubData should succeed now that not double-bound");
gl.bindBuffer(gl.ARRAY_BUFFER, null);

debug("<hr/>Test bufferData family with tf object unbound");
Expand Down
Loading