-
Notifications
You must be signed in to change notification settings - Fork 710
Added Omron B3FS tactile switch series. #2052
Conversation
Hi @cnieves1 you've been doing a ton of library work. Would you be interested in joining the kicad librarians team to help review pull requests for symbols, footprints, 3d models etc? If you are interested I can mention it to the team leads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the data sheet in the description for the parts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a silk screen hat/corner like Nidec_Copal_SH-7010A to indicate pin 1? Most of the push buttons don't have it but they are also pins 1 and 1 up top and 2 and 2 on the bottom so direction isn't important like it is for these three.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the side courtyard to be 0.25mm away from the pads and fab? It looks like its 0.25mm from the pad (which is good), but from the center of the fab line to the center of the courtyard line on the sides its 0.42. Top and bottom courtyard lines look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback on a few things, otherwise the footprints look good.
Seems TravisCI is checking other footprints than those in this PR. The three contributed here seem ok:
|
Thanks! It is not so much time since I started to use Kicad. |
Hi @cnieves1, you've created so many parts now that you've got the pre-requisites out of the way for sure. If you are interested you could review a couple of pull requests against the KLC and the other feedback I've given on your other PRs as practice. |
Hi @chmorgan, should I do that commenting as a normal user or is anything more required? |
@cnieves1 you could do that as a normal user. Do an @ mention of me and I can take a look too. Then we can discuss with the others on the team if you'd like to join as a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed pad locations match datasheet, fab dimensions match datasheet, courtyard margins of 0.25mm, PIN numbers match. Part datasheet in description.
Datasheet: https://omronfs.omron.com/en_US/ecb/products/pdf/en-b3fs.pdf
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)