Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added Omron B3FS tactile switch series. #2052

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Conversation

cnieves1
Copy link
Contributor

@cnieves1 cnieves1 commented Jan 13, 2020

Datasheet: https://omronfs.omron.com/en_US/ecb/products/pdf/en-b3fs.pdf

imagen

imagen


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@cnieves1
Copy link
Contributor Author

3D: KiCad/kicad-packages3D#647

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jan 19, 2020
@chmorgan chmorgan self-requested a review March 15, 2020 14:49
@chmorgan chmorgan self-assigned this Mar 15, 2020
@chmorgan
Copy link
Collaborator

Hi @cnieves1 you've been doing a ton of library work. Would you be interested in joining the kicad librarians team to help review pull requests for symbols, footprints, 3d models etc? If you are interested I can mention it to the team leads.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the data sheet in the description for the parts?

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a silk screen hat/corner like Nidec_Copal_SH-7010A to indicate pin 1? Most of the push buttons don't have it but they are also pins 1 and 1 up top and 2 and 2 on the bottom so direction isn't important like it is for these three.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the side courtyard to be 0.25mm away from the pads and fab? It looks like its 0.25mm from the pad (which is good), but from the center of the fab line to the center of the courtyard line on the sides its 0.42. Top and bottom courtyard lines look good.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback on a few things, otherwise the footprints look good.

@cnieves1
Copy link
Contributor Author

Seems TravisCI is checking other footprints than those in this PR. The three contributed here seem ok:

Checking: Button_Switch_SMD.pretty/SW_SPST_Omron_B3FS-100xP.kicad_mod
Checking footprint 'SW_SPST_Omron_B3FS-100xP' - No errors
Checking: Button_Switch_SMD.pretty/SW_SPST_Omron_B3FS-101xP.kicad_mod
Checking footprint 'SW_SPST_Omron_B3FS-101xP' - No errors
Checking: Button_Switch_SMD.pretty/SW_SPST_Omron_B3FS-105xP.kicad_mod
Checking footprint 'SW_SPST_Omron_B3FS-105xP' - No errors
Checking: Button_Switch_THT.pretty/SW_Tactile_SKHH_Angled.kicad_mod

@cnieves1
Copy link
Contributor Author

Hi @cnieves1 you've been doing a ton of library work. Would you be interested in joining the kicad librarians team to help review pull requests for symbols, footprints, 3d models etc? If you are interested I can mention it to the team leads.

Thanks! It is not so much time since I started to use Kicad.
I will try to do my best, but at least for the beginning, I would prefer if someone could review what I do...
I really don't know anything about librarian's work... Is there any librarian beginner's guide?

@chmorgan
Copy link
Collaborator

Hi @cnieves1, you've created so many parts now that you've got the pre-requisites out of the way for sure. If you are interested you could review a couple of pull requests against the KLC and the other feedback I've given on your other PRs as practice.

@cnieves1
Copy link
Contributor Author

Hi @chmorgan, should I do that commenting as a normal user or is anything more required?

@chmorgan
Copy link
Collaborator

@cnieves1 you could do that as a normal user. Do an @ mention of me and I can take a look too. Then we can discuss with the others on the team if you'd like to join as a reviewer.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed pad locations match datasheet, fab dimensions match datasheet, courtyard margins of 0.25mm, PIN numbers match. Part datasheet in description.

@chmorgan chmorgan merged commit 5f7b061 into KiCad:master Mar 17, 2020
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Mar 18, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants