Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added 3D for Omron B3FS-105xP. #647

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

cnieves1
Copy link
Contributor

Datasheet: https://omronfs.omron.com/en_US/ecb/products/pdf/en-b3fs.pdf
3D source: KiCad/kicad-packages3D-source#258
Footprint: KiCad/kicad-footprints#2052

imagen

imagen


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@myfreescalewebpage myfreescalewebpage added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Jan 23, 2020
@chmorgan chmorgan self-requested a review March 17, 2020 21:50
@chmorgan chmorgan self-assigned this Mar 17, 2020
Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed alignment with footprints and checked step file in freecad

@chmorgan chmorgan merged commit 313df82 into KiCad:master Mar 17, 2020
@easyw
Copy link
Contributor

easyw commented Mar 18, 2020

@chmorgan
I've checked the file and it seems the wrl model doesn't apply the correct materials to the 3d model...
particularly the pins should be
material DEF PIN-01 Material
instead of
material DEF MET-01 Material
Have you checked that WRL model uses correct material properties, as requested in the KLC?

@cnieves1
Copy link
Contributor Author

I've changed that and pushed the changes to my branches (both 3D source and 3D model).
As this PR is closed, it doesn't update the changes. Should I open a new PR?

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Mar 18, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Mar 18, 2020
@chmorgan
Copy link
Collaborator

Hi @easyw. I did not check the material properties but I will going forward. Sorry about that.

@cnieves1 can you open a new PR and correct the properties for this part? I can review and then confirm with @easyw and we can get that resolved.

@cnieves1
Copy link
Contributor Author

Done. Please see:
KiCad/kicad-packages3D-source#269
#666

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants