Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Omron B3FS-105xP: Changed pin material different from metal body part. #666

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

cnieves1
Copy link
Contributor

Fix for #647

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@cnieves1
Copy link
Contributor Author

@easyw @chmorgan can you review this?

@cnieves1 cnieves1 changed the title Changed pin material different from metal body part. Omron B3FS-105xP: Changed pin material different from metal body part. Mar 18, 2020
@cnieves1 cnieves1 mentioned this pull request Mar 18, 2020
8 tasks
Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@easyw this looks good to me now, both in kicad 3d and in freecad. Can you confirm?

@easyw
Copy link
Contributor

easyw commented Mar 19, 2020

@chmorgan @cnieves1
this time seems fine! thx
PS @chmorgan could you ave a look at this issue?

@chmorgan chmorgan merged commit 65e2786 into KiCad:master Mar 20, 2020
@antoniovazquezblanco antoniovazquezblanco added the Enhancement Improves existing package 3D in the library label Mar 20, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing package 3D in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants