COMP: fixed cppcheck warnings about identical options in ternary oper…

…ator Probably was a way to avoid unused variable warnings. Added itkNotUsed instead.
Kitware · Jan 7, 2025 · cfec55a · cfec55a
1 parent b7c6cb4
commit cfec55a
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/Modules/Core/Common/include/itkNumericTraits.h b/Modules/Core/Common/include/itkNumericTraits.h
@@ -308,14 +308,14 @@ class NumericTraits<bool> : public std::numeric_limits<bool>
     return !val;
   }
   static constexpr bool
-  IsNegative(bool val)
+  IsNegative(bool itkNotUsed(val))
   {
-    return val ? false : false;
+    return false;
   }
   static constexpr bool
-  IsNonnegative(bool val)
+  IsNonnegative(bool itkNotUsed(val))
   {
-    return val ? true : true;
+    return true;
   }
   static constexpr bool IsSigned = false;
   static constexpr bool IsInteger = true;
@@ -640,14 +640,14 @@ class NumericTraits<unsigned char> : public std::numeric_limits<unsigned char>
     return val == Zero;
   }
   static constexpr bool
-  IsNegative(unsigned char val)
+  IsNegative(unsigned char itkNotUsed(val))
   {
-    return val ? false : false;
+    return false;
   }
   static constexpr bool
-  IsNonnegative(unsigned char val)
+  IsNonnegative(unsigned char itkNotUsed(val))
   {
-    return val ? true : true;
+    return true;
   }
   static constexpr bool IsSigned = false;
   static constexpr bool IsInteger = true;
@@ -845,14 +845,14 @@ class NumericTraits<unsigned short> : public std::numeric_limits<unsigned short>
     return val == Zero;
   }
   static constexpr bool
-  IsNegative(unsigned short val)
+  IsNegative(unsigned short itkNotUsed(val))
   {
-    return val ? false : false;
+    return false;
   }
   static constexpr bool
-  IsNonnegative(unsigned short val)
+  IsNonnegative(unsigned short itkNotUsed(val))
   {
-    return val ? true : true;
+    return true;
   }
   static constexpr bool IsSigned = false;
   static constexpr bool IsInteger = true;
@@ -1069,14 +1069,14 @@ class NumericTraits<unsigned int> : public std::numeric_limits<unsigned int>
     return val == Zero;
   }
   static constexpr bool
-  IsNegative(unsigned int val)
+  IsNegative(unsigned int itkNotUsed(val))
   {
-    return val ? false : false;
+    return false;
   }
   static constexpr bool
-  IsNonnegative(unsigned int val)
+  IsNonnegative(unsigned int itkNotUsed(val))
   {
-    return val ? true : true;
+    return true;
   }
   static constexpr bool IsSigned = false;
   static constexpr bool IsInteger = true;