Skip to content

Commit

Permalink
refactor: move javascript code to its own top-level directory
Browse files Browse the repository at this point in the history
annehaley committed Jun 18, 2024
1 parent 3247611 commit 7aa8ea9
Showing 9 changed files with 1 addition and 1 deletion.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ requires = ["setuptools>=61", "wheel"]
build-backend = "setuptools.build_meta"

[tool.setuptools]
packages = ["pan3d", "pan3d.ui", "pan3d.ui.vue", "pan3d.ui.vue.module", "pan3d.catalogs"]
packages = ["pan3d", "pan3d.ui", "pan3d.ui.vue", "pan3d-js.serve", "pan3d.catalogs"]

This comment has been minimized.

Copy link
@jourdain

jourdain Jun 18, 2024

Collaborator

The all point of that is to exclude the JS source from the python package (So don't add pan3d-js at all).
The serve directory should be inside pan3d/.../module/serve

This comment has been minimized.

Copy link
@annehaley

annehaley Jun 18, 2024

Author Member

Does that mean that the "build" script defined in package.json should specify an output directory in the pan3d/ui folder?

This comment has been minimized.

Copy link
@jourdain

jourdain Jun 18, 2024

Collaborator

Also why did you move Python code into the JavaScript package?
Again the point of that change is to properly split JS vs Python.
It is true that the Python leverage some JS, but that should only be the generated code, not the source...

This comment has been minimized.

Copy link
@annehaley

annehaley Jun 18, 2024

Author Member

I see what you mean, I can put the module folder back. It's a lot of semantic separation, but I understand that the differnent languages should be the organizational barrier. Also, disregard my previous comment; I see where the output directory of the build command is defined in vite.config.js; I'll change the path there.


[tool.semantic_release]
version_variables = ["setup.py:__version__"]

0 comments on commit 7aa8ea9

Please sign in to comment.