-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Coordinate Indexing & Slicing #78
Conversation
I went through alot of the visualization features and everything works fine for me. There were a couple things that did not work as expected, though they might not be due to this PR (I didn't go back and compare with pan3d:main branch).
|
@johnkit I was able to test importing your state file, and I'm seeing expected behavior (video attached). This dataset does take a long time to load, though, so the loading bar does animate for a while. When you tried this, did the loading bar not appear? pan3d-slow-import.mp4Also, in cartography mode, the center of rotation is currently set to [0, 0, 0], which should be the center of the earth: pan3d_cartographic_spin.mp4 |
This PR includes the following changes:
resolution
argument to theDatasetBuilder
(also available as a CLI arg). If not specified,resolution
defaults to 128. This value is used for auto-slicing, where the step value is inferred from the start and stop values and the resolution. If the user specifies a value <=1, auto-slicing will be disabled. If auto-slicing is disabled, the user may edit start, stop, and step in the Axis Drawer (previous implementation).pan3d/ui/vue
folder. This widget displays a preview image of one face of the rendered 3d structure and uses SVG elements to allow the user to resize a selection box which changes the bounds of the two coordinates along that face. The user may select which face to preview, and clicking the camera button next to this input will snap the camera to view that face. When this widget is shown, the two sliders which represent coordinates changed by the selection box will disappear. The time slider and the slider for the axis normal to the selected face will still be available.