fix(Colors): fix UInt8Clamped array color definition #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@finetjul This PR i solves the problem with color defined with UInt8Clamped arrays |
finetjul
reviewed
Mar 19, 2024
| @@ -15,6 +15,7 @@ export const VtkDataTypes = { | |||
| CHAR: 'Int8Array', | |||
| SIGNED_CHAR: 'Int8Array', | |||
| UNSIGNED_CHAR: 'Uint8Array', | |||
| UNSIGNED_CHAR_CLAMPED: 'Uint8ClampedArray', | |||
There was a problem hiding this comment.
The problem here is for UCHAR we have two possible values...
There was a problem hiding this comment.
My first guess is that this won't affect VTK compatibility, since these constants need to be mapped to the VTK equivalents anyways.
There was a problem hiding this comment.
@rodrigobasilio2022 maybe add an inline comment that says it "should be used for VTK.js internal purpose only (e.g.GPU)"
There was a problem hiding this comment.
@finetjul Done squash
finetjul
approved these changes
Mar 20, 2024
rodrigobasilio2022
force-pushed
the
fix/UInt8Clamped
branch
from
5e2be69 to
08d1f28
Compare
Done quash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes a bug in vtk.js when one creates a color definition with UInt8Clamped array structure
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting