Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Colors): fix UInt8Clamped array color definition #3034

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix(Colors): fix UInt8Clamped array color definition #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Common/Core/DataArray/Constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const VtkDataTypes = {
CHAR: 'Int8Array',
SIGNED_CHAR: 'Int8Array',
UNSIGNED_CHAR: 'Uint8Array',
UNSIGNED_CHAR_CLAMPED: 'Uint8ClampedArray', // should be used for VTK.js internal purpose only
SHORT: 'Int16Array',
UNSIGNED_SHORT: 'Uint16Array',
INT: 'Int32Array',
Expand Down
3 changes: 2 additions & 1 deletion Sources/Common/Core/ScalarsToColors/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ function vtkScalarsToColors(publicAPI, model) {
// map scalars through lookup table only if needed
if (
(colorMode === ColorMode.DEFAULT &&
scalars.getDataType() === VtkDataTypes.UNSIGNED_CHAR) ||
(scalars.getDataType() === VtkDataTypes.UNSIGNED_CHAR ||
scalars.getDataType() === VtkDataTypes.UNSIGNED_CHAR_CLAMPED)) ||
(colorMode === ColorMode.DIRECT_SCALARS && scalars)
) {
newColors = publicAPI.convertToRGBA(
Expand Down
Loading