chore(changelog): make it more usable #11519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make -C CHANGELOG` to use it. KAG-2527
repo's naming conventions
github-actions
bot
added
core/docs
chore
vm-001
reviewed
Sep 7, 2023
| echo | ||
|
|
||
| echo "What is the type of the change (feature, bugfix, dependency, deprecation, breaking_change, performance)?" | ||
| select type in feature bugfix dependency deprecation breaking_change performance; do |
There was a problem hiding this comment.
The enum of type and scope are defined in the CHANGELOG/schema.json, Do you think removing hard code(feature|bugfix|dependency|deprecation|breaking_change|performance) here would make things more consistent?
There was a problem hiding this comment.
Temporary measure, let's discuss later. We need something more reasonable immediately.
kikito
reviewed
Sep 19, 2023
| id: changelog-check | ||
| uses: tj-actions/changed-files@2f7246cb26e8bb6709b6cbfc1fec7febfe82e96a # v37 | ||
| with: | ||
| files: 'CHANGELOG/unreleased/**/*.yaml' |
There was a problem hiding this comment.
Since we have open PRs using the .yaml extension instead of yml, could we support both file extensions for a while (until everyone is using the new system)? Then we can rename everything to .yml and stop supporting yaml.
team-eng-enablement
added
the
author/community
|
Superseded by #11652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.