-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(changelog): make it more usable #11519
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
.PHONY: new install_dependencies | ||
|
||
new: | ||
./new.sh | ||
|
||
install_dependencies: | ||
luarocks install penlight --local | ||
luarocks install lyaml --local |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
#!/bin/bash | ||
set -e | ||
|
||
echo "What is this changelog for (kong, kong-ee, kong-manager)?" | ||
select component in kong kong-ee kong-manager; do | ||
case $component in | ||
kong|kong-ee|kong-manager) break;; | ||
*) echo "Invalid option. Please select again.";; | ||
esac | ||
done | ||
|
||
echo | ||
|
||
read -p "What is the title of the change? " title | ||
|
||
echo | ||
|
||
echo "What is the type of the change (feature, bugfix, dependency, deprecation, breaking_change, performance)?" | ||
select type in feature bugfix dependency deprecation breaking_change performance; do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The enum of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Temporary measure, let's discuss later. We need something more reasonable immediately. |
||
case $type in | ||
feature|bugfix|dependency|deprecation|breaking_change|performance) break;; | ||
*) echo "Invalid option. Please select again.";; | ||
esac | ||
done | ||
|
||
echo | ||
|
||
echo "What is the scope of the change (Core, Plugin, PDK, Admin API, Performance, Configuration, Clustering)?" | ||
select scope in Core Plugin PDK "Admin API" Performance Configuration Clustering; do | ||
case $scope in | ||
Core|Plugin|PDK|"Admin API"|Performance|Configuration|Clustering) break;; | ||
*) echo "Invalid option. Please select again.";; | ||
esac | ||
done | ||
|
||
echo | ||
|
||
read -p "What are the associated PRs? (comma-separated, without spaces e.g. 123,124,125) " pr_input | ||
IFS=',' read -ra prs <<< "$pr_input" | ||
|
||
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||
file_name="$SCRIPT_DIR/unreleased/$component/${prs[0]:-unknown}.yml" | ||
|
||
echo | ||
|
||
echo "New changelog will be created at $file_name" | ||
|
||
echo | ||
|
||
read -p "What are the associated Jira tickets? (comma-separated, without spaces e.g. FTI-123,FTI-124) " jira_input | ||
IFS=',' read -ra jiras <<< "$jira_input" | ||
|
||
echo | ||
|
||
read -p "What are the associated issues? (comma-separated, without spaces e.g. 123,124,125) " issue_input | ||
IFS=',' read -ra issues <<< "$issue_input" | ||
|
||
echo "message: $title" > $file_name | ||
echo "type: $type" >> $file_name | ||
echo "scope: $scope" >> $file_name | ||
echo "prs:" >> $file_name | ||
for pr in "${prs[@]}"; do | ||
echo " - $pr" >> $file_name | ||
done | ||
echo "jiras:" >> $file_name | ||
for jira in "${jiras[@]}"; do | ||
echo " - \"$jira\"" >> $file_name | ||
done | ||
echo "issues:" >> $file_name | ||
for issue in "${issues[@]}"; do | ||
echo " - $issue" >> $file_name | ||
done | ||
|
||
echo | ||
|
||
echo "Changelog file generated as $file_name:" | ||
echo "Be sure to \"git add\" and \"git commit\" this file" | ||
echo "================================================================" | ||
cat $file_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have open PRs using the .yaml extension instead of yml, could we support both file extensions for a while (until everyone is using the new system)? Then we can rename everything to .yml and stop supporting yaml.