-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expression router): implement query parameter match of HTTPRoute #4780
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4780 +/- ##
=======================================
- Coverage 77.7% 77.6% -0.2%
=======================================
Files 164 164
Lines 18399 18443 +44
=======================================
+ Hits 14298 14313 +15
- Misses 3281 3305 +24
- Partials 820 825 +5
☔ View full report in Codecov by Sentry. |
2744a4e
to
35d67ad
Compare
35d67ad
to
1da3096
Compare
1da3096
to
6d0fa9f
Compare
5f6e16c
to
5287edc
Compare
73dca94
5287edc
to
73dca94
Compare
Conformance tests failed :(
|
@pmalek it is because the helm chart version is NOT updated to the latest by the renovate:
Merging #4846 not only made conflicts for the PR, but also changed helm chart version used in conformance tests back. It should be fixed after renovate updates charts version to the latest. |
73dca94
to
ddb00fe
Compare
ddb00fe
to
73fe14d
Compare
What this PR does / why we need it:
implement query parameter matching in
HTTPRoute
.Which issue this PR fixes:
fixes #3679
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR