-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): remove sample access key from SDK documentation #102
chore(*): remove sample access key from SDK documentation #102
Conversation
|
I'm considering whether removing all the document fields is a good idea since we don't actually need those things and that could probably also help us maintain smaller JSON files |
Co-authored-by: Thijs Schreijer <[email protected]>
@windmgc we can do it. But I try to minimize the change for this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a chaneglog entry before merging
Co-authored-by: Thijs Schreijer <[email protected]>
In the AWS SDK, there is sample access key sample
wJalrXUtnFEMI
that may trigger CVE report. This PR tries to remove it.This is a dangerous operation! Before merge, we must ensure only the access key sample is removed!
FTI-5732 FTI-5732