hotfix(config) fix external ngx-wasm-rs builds #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
hotfix/externalized-cargo
branch
3 times, most recently
from
a6e9413
to
8b11f83
Compare
First this fixes the test cases and documentation as they were merged
(with edits), which wrongly assumed `NGX_CC_OPT` and `NGX_LD_OPT` were
digested by Nginx's `auto` scripts, they are not. They are derived from
`--with-{cc,ld}-opt` arguments.
Second, it moves defines and mandatory checks to `config` since we need
both even when `NGX_WASM_CARGO=0` and `auto/cargo` does not run.
The above fixes `NGX_WASM_CARGO=0` as a mean to *completely* disable
ngx-wasm-rs, as supported by Wasmer. This "mandatory={yes,no}" behavior
is tested for both Wasmer and V8 as well.
Finally, we also consider `NGX_WASM_CARGO` in the local development
environment freshness build script.
thibaultcha
force-pushed
the
hotfix/externalized-cargo
branch
from
8b11f83
to
52c6807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First this fixes the test cases and documentation as they were merged, which wrongly assumed
NGX_CC_OPTandNGX_LD_OPTwere digested by Nginx'sautoscripts, they are not. They are derived from--with-{cc,ld}-optarguments.Second, it moves defines and mandatory checks to
configsince we need both even whenNGX_WASM_CARGO=0andauto/cargodoes not run.The above fixes
NGX_WASM_CARGO=0as a mean to completely disable ngx-wasm-rs, as supported by Wasmer. This "mandatory={yes,no}" behavior is tested for both Wasmer and V8 as well.Finally, we also consider
NGX_WASM_CARGOin the local development environment freshness build script.