Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(config) fix external ngx-wasm-rs builds #389

Merged
merged 1 commit into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. hotfix(config) fix external ngx-wasm-rs builds

    First this fixes the test cases and documentation as they were merged
    (with edits), which wrongly assumed `NGX_CC_OPT` and `NGX_LD_OPT` were
    digested by Nginx's `auto` scripts, they are not. They are derived from
    `--with-{cc,ld}-opt` arguments.
    
    Second, it moves defines and mandatory checks to `config` since we need
    both even when `NGX_WASM_CARGO=0` and `auto/cargo` does not run.
    
    The above fixes `NGX_WASM_CARGO=0` as a mean to *completely* disable
    ngx-wasm-rs, as supported by Wasmer. This "mandatory={yes,no}" behavior
    is tested for both Wasmer and V8 as well.
    
    Finally, we also consider `NGX_WASM_CARGO` in the local development
    environment freshness build script.
    thibaultcha committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    52c6807 View commit details
    Browse the repository at this point in the history