Skip to content

Commit

Permalink
Merge pull request #493 from KxSystems/ee-fixes
Browse files Browse the repository at this point in the history
Fixed qsql target added underscore
  • Loading branch information
ecmel authored Jan 14, 2025
2 parents fe87ed5 + d2cb725 commit db1cd23
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions src/webview/components/kdbDataSourceView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class KdbDataSourceView extends LitElement {
static styles = [shoelaceStyles, dataSourceStyles];

readonly vscode = acquireVsCodeApi();
private declare debounce;
declare private debounce;

isInsights = false;
isMetaLoaded = false;
Expand Down Expand Up @@ -318,7 +318,9 @@ export class KdbDataSourceView extends LitElement {
if (!this.qsqlTarget) {
this.qsqlTarget = value;
}
return html`<sl-option value="${value}">${value}</sl-option>`;
return html`<sl-option value="${encodeURIComponent(value)}"
>${value}</sl-option
>`;
});
}
return [];
Expand Down Expand Up @@ -816,12 +818,16 @@ export class KdbDataSourceView extends LitElement {
<div class="col">
<sl-select
label="Target"
.value="${live(this.qsqlTarget)}"
.value="${live(encodeURIComponent(this.qsqlTarget))}"
@sl-change="${(event: Event) => {
this.qsqlTarget = (event.target as HTMLSelectElement).value;
this.qsqlTarget = decodeURIComponent(
(event.target as HTMLSelectElement).value,
);
this.requestChange();
}}">
<sl-option .value="${live(this.qsqlTarget)}" .selected="${live(true)}"
<sl-option
.value="${live(encodeURIComponent(this.qsqlTarget))}"
.selected="${live(true)}"
>${this.qsqlTarget || "(none)"}</sl-option
>
<small
Expand Down

0 comments on commit db1cd23

Please sign in to comment.