Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Clean (Part 1) #129

Merged
merged 29 commits into from
Mar 5, 2024
Merged

Spring Clean (Part 1) #129

merged 29 commits into from
Mar 5, 2024

Conversation

jws-1
Copy link
Member

@jws-1 jws-1 commented Feb 15, 2024

  • Remove lasr_speech package.
  • Cleanup lasr_voice - there is currently a bug caused by not setting an entry in rosparam.
  • Cleanup lasr_rasa.
  • Drop aruco_ros submodule.
  • Drop tf_module - we are now in noetic, which gets rid of our tf woes!
  • Drop other unused legacy packages.
  • Construct cv2_pcl package from common_math, and remove the latter.
  • CATKIN_IGNORE legacy packages and tasks - we have created an archive branch so that these tasks can be run. At some point we should refactor them so that they run under the new codebase.
  • Cleanup some of the vision skills (i.e. correct use of userdata!).
  • Add 3D variant of YOLO service. This should reduce boiler plate code of the form: pcl -> img -> yolo -> masks -> centroids.
  • Create marker helper package for visualising point estimates.

NOTE: This PR will break some existing functionality - particularly the coffee_shop and lift tasks, but may also affect the receptionist task too.

@jws-1 jws-1 marked this pull request as ready for review March 5, 2024 09:55
@jws-1 jws-1 requested a review from m-barker March 5, 2024 10:03
Copy link
Collaborator

@m-barker m-barker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants