Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpsr-talk-skill #160

Merged
merged 7 commits into from
Apr 21, 2024
Merged

Gpsr-talk-skill #160

merged 7 commits into from
Apr 21, 2024

Conversation

m-barker
Copy link
Collaborator

This PR adds a state machine to handle the "talk" GPSR subtask, where we need to generate a set of pre-defined responses to a given input list, and say this to a specified person (which will be handeled by a separate skill.

@m-barker m-barker requested a review from jws-1 April 18, 2024 14:42
Copy link
Member

@jws-1 jws-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, couple of minor points I think we need to consider before we merge this in though.

Great job! 👍

tasks/gpsr/src/gpsr/states/__init__.py Outdated Show resolved Hide resolved
tasks/gpsr/src/gpsr/states/talk.py Outdated Show resolved Hide resolved
tasks/gpsr/src/gpsr/states/talk.py Outdated Show resolved Hide resolved
tasks/gpsr/src/gpsr/states/talk.py Outdated Show resolved Hide resolved
@m-barker m-barker requested a review from jws-1 April 19, 2024 16:53
Copy link
Member

@jws-1 jws-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jws-1 jws-1 merged commit 6b03a06 into LASR-at-Home:main Apr 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants