Fix non-mandatory event IDs #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #254 SBML says that IDs on events are actually not mandatory, this softens the data structure so that the ID-less events are supported. The vector-of-pairs implementation is chosen for backwards compatibility (iteration through a vector of pairs should work precisely like iteration through the dictionary that was there before). Notably, this might look like a breaking change _but_ it is not -- the main use case that is broken by this commit is indexing the events by ID, which was actually broken already.
exaexa
force-pushed
the
mk-fix-event-ids
branch
from
4191514
to
df38e09
Compare
|
cc @sebapersson -- I added one of the models you reported as a test so this should technically work, but it would ne great if you could check if your usecase is solved. Thanks! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 10 10
Lines 817 817
=======================================
Hits 764 764
Misses 53 53
☔ View full report in Codecov by Sentry. |
paulflang
approved these changes
Aug 28, 2023
stelmo
approved these changes
Aug 28, 2023
Thanks, it now works for my usercase. |
|
Perfect, thanks all for confirms! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly fixes #254 using approach #1. As a result, some new SBML usecases can be loaded.
I packed in the UL logo update (the original relied on line width setting and rendering, which is typically broken.
Also bumping to 1.5.0 (the new loadable models are a feature, also see discussion in the commits).