Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-mandatory event IDs #255

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix non-mandatory event IDs #255

merged 2 commits into from
Aug 30, 2023

Commits on Aug 28, 2023

  1. side fix of the unilu logo

    @exaexa
    exaexa committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    eb702f7 View commit details
    Browse the repository at this point in the history

  2. remove the mandatory ID from the SBML events 

    Closes #254

SBML says that IDs on events are actually not mandatory, this softens the data
structure so that the ID-less events are supported. The vector-of-pairs
implementation is chosen for backwards compatibility (iteration through a
vector of pairs should work precisely like iteration through the dictionary
that was there before). Notably, this might look like a breaking change _but_
it is not -- the main use case that is broken by this commit is indexing the
events by ID, which was actually broken already.
    @exaexa
    exaexa committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    df38e09 View commit details
    Browse the repository at this point in the history