Feature/ci gcc versions #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moves mpich tests on ubuntu24.04 from CI
ryan-dozier
pushed a commit
to ryan-dozier/ygm
that referenced
this pull request
Nov 6, 2024
* Adding newer versions of GCC to Github actions * Fixing gcc version in CI * Fixing indentation * Trying to fix gcc-13 * Attempting to fix gcc versions * Includes algorithm in ygm_traits to be able to use * Adds safeguards against running on one rank in test_collective and removes mpich tests on ubuntu24.04 from CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly testing ubuntu-24.04 since ubuntu-latest may or may not point to ubuntu-24.04 (see here).
In making this change, I discovered mpich is broken on Ubuntu 24.04 (link). Removing mpich tests on ubuntu-24.04 for the time being and will add them back in at a later date.
Adds tests for newer versions of GCC that are available on Ubuntu 24.04.