Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci gcc versions #269

Merged
merged 13 commits into from
Oct 18, 2024
20 changes: 14 additions & 6 deletions .github/workflows/ci-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,23 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, ubuntu-22.04]
gcc-version: [11, 12]
os: [ubuntu-24.04, ubuntu-22.04]
gcc-version: [11, 12, 13, 14]
mpi-type: [mpich, openmpi]
exclude:
- os: ubuntu-latest
gcc-version: 8
- os: ubuntu-22.04
gcc-version: 13
- os: ubuntu-22.04
gcc-version: 14
- os: ubuntu-24.04
mpi-type: mpich
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Update apt
run: |
sudo add-apt-repository -y universe
sudo apt-get update
- name: Cache boost
uses: actions/cache@v4
id: cache-boost
Expand All @@ -49,8 +57,8 @@ jobs:
if: matrix.mpi-type == 'openmpi'
run: sudo apt-get install openmpi-bin libopenmpi-dev
- name: Install GCC-${{ matrix.gcc-version }}
if: matrix.gcc-version == '8'
run: sudo apt-get install gcc-8 g++-8
if: (matrix.gcc-version == '11' && matrix.os == 'ubuntu-24.04')
run: sudo apt-get install gcc-11 g++-11
- name: Make
run: |
echo Run 'make'
Expand Down
1 change: 1 addition & 0 deletions include/ygm/detail/ygm_traits.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// SPDX-License-Identifier: MIT

#pragma once
#include <algorithm>
#include <type_traits>

namespace ygm::detail {
Expand Down
10 changes: 7 additions & 3 deletions test/test_collective.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,16 @@ int main(int argc, char** argv) {
string_set.insert("Aggs");
}

YGM_ASSERT_RELEASE(not is_same(string_set, world));
if (world.size() > 1) {
YGM_ASSERT_RELEASE(not is_same(string_set, world));
}
string_set.insert("Howdy");
string_set.insert("Aggs");
YGM_ASSERT_RELEASE(is_same(string_set, world));

YGM_ASSERT_RELEASE(not is_same(world.rank(), world));
if (world.size() > 1) {
YGM_ASSERT_RELEASE(not is_same(world.rank(), world));
}

return 0;
}
}