Primer code review - Fabiola González #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HectorBlisS
suggested changes
Feb 11, 2020
src/pruebas.js
Outdated
Comment on lines
15
to
19
| var letterOriginal= inputText.charAt(i); | ||
| var letter = letterOriginal.toUpperCase(); | ||
| var letterCode = letter.charCodeAt(); | ||
| var letterCodeNumber = parseInt(letterCode); | ||
| if(letterCodeNumber == 32){ |
There was a problem hiding this comment.
Es importante cambiar var por let o const (la mayoría pide const aunque no hay gran diferencia entre let y const es un debate) pero var compromete tu código, ya no lo uses.
src/pruebas.js
Outdated
| }else{ | ||
| codeNumberCiphered = (letterCodeNumber-65+offset)%26+65; | ||
| } | ||
| var cipheredLetter = String.fromCharCode(codeNumberCiphered); |
| codeNumberCiphered = (letterCodeNumber-65+offset)%26+65; | ||
| } | ||
| var cipheredLetter = String.fromCharCode(codeNumberCiphered); | ||
| console.log(letter+" "+letterCode+" "+codeNumberCiphered+" "+cipheredLetter); |
There was a problem hiding this comment.
de preferencia crea una variable que almacene todo esto y despues solo le das al console log la variable
src/style.css
Outdated
| background-color: #2196F3; | ||
| } | ||
|
|
||
| input:focus + .slider { |
There was a problem hiding this comment.
Esto es muy específico y está bien, pero puede fallar, mejor usa el selector de descendente (espacio) en vez del + para que sea más seguro
…ffset and special characters, including ñand space, remain the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Para el cipher, generé un archivo llamado pruebas.js que contiene todo lo que he trabajado al respecto. Sin embargo, ya he puesto mi función en el objeto cipher del archivo cipher.js
En HTML solo tengo estructurada la maqueta pero aún faltan estilos de css.
¡Gracias!