Primer code review - Fabiola González #23
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
|
|
||
| //var inputText= "Este es un texto de prueba."; | ||
| var inputText= "FTUF FT VO UFYUP EF QSVFCB"; | ||
| var offset = -1; | ||
| var outputText = []; | ||
|
|
||
| console.log("texto:"+inputText+" - "+"offset:"+offset); | ||
| cipher(inputText, offset, outputText); | ||
| //console.log(cipheredLetter); | ||
| console.log(outputText.join("")); | ||
|
|
||
| function cipher(){ | ||
|
|
||
| for (i in inputText){ | ||
| var letterOriginal= inputText.charAt(i); | ||
| var letter = letterOriginal.toUpperCase(); | ||
| var letterCode = letter.charCodeAt(); | ||
| var letterCodeNumber = parseInt(letterCode); | ||
| if(letterCodeNumber == 32){ | ||
| codeNumberCiphered = letterCodeNumber; | ||
| }else{ | ||
| codeNumberCiphered = (letterCodeNumber-65+offset)%26+65; | ||
| } | ||
| var cipheredLetter = String.fromCharCode(codeNumberCiphered); | ||
|
|
||
| console.log(letter+" "+letterCode+" "+codeNumberCiphered+" "+cipheredLetter); | ||
|
There was a problem hiding this comment. de preferencia crea una variable que almacene todo esto y despues solo le das al console log la variable |
||
| //return cipheredLetter; | ||
| outputText.push(cipheredLetter); | ||
| } | ||
| return outputText; | ||
| //console.log("texto cifrado:"+outputText.join("")); | ||
| /* var outputText = ["Que"]; | ||
| var outputText = outputText.push(cipheredLetter); | ||
| console.log("texto cifrado:"+outputText);*/ | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| html, body{ | ||
| margin:0; | ||
| padding:0; | ||
| background-color: #c7e6e6; | ||
| text-align: center; | ||
| display: inline-block; | ||
| height: 100%; | ||
| vertical-align:middle; | ||
|
|
||
| } | ||
|
|
||
| section{ | ||
| border: 1px solid black; | ||
| margin: 0 auto; | ||
| height: 100%; | ||
| } | ||
|
|
||
| .logo{ | ||
| width: 15%; | ||
| } | ||
|
|
||
| #bluetoothLabel{ | ||
| float: left; | ||
| } | ||
|
|
||
| .configBox{ | ||
| display: inline-block; | ||
| } | ||
|
|
||
| /* Estilo para toogle switch que activa el Bluetooth */ | ||
| /* The switch - the box around the slider */ | ||
| .switch { | ||
| position: relative; | ||
| display: inline-block; | ||
| width: 60px; | ||
| height: 34px; | ||
| } | ||
|
|
||
| /* Hide default HTML checkbox */ | ||
| .switch input { | ||
| opacity: 0; | ||
| width: 0; | ||
| height: 0; | ||
| } | ||
|
|
||
| /* The slider */ | ||
| .slider { | ||
| position: absolute; | ||
| cursor: pointer; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| background-color: #ccc; | ||
| -webkit-transition: .4s; | ||
| transition: .4s; | ||
| } | ||
|
|
||
| .slider:before { | ||
| position: absolute; | ||
| content: ""; | ||
| height: 26px; | ||
| width: 26px; | ||
| left: 4px; | ||
| bottom: 4px; | ||
| background-color: white; | ||
| -webkit-transition: .4s; | ||
| transition: .4s; | ||
| } | ||
|
|
||
| input:checked + .slider { | ||
| background-color: #2196F3; | ||
| } | ||
|
|
||
| input:focus + .slider { | ||
|
There was a problem hiding this comment. Esto es muy específico y está bien, pero puede fallar, mejor usa el selector de descendente (espacio) en vez del + para que sea más seguro |
||
| box-shadow: 0 0 1px #2196F3; | ||
| } | ||
|
|
||
| input:checked + .slider:before { | ||
| -webkit-transform: translateX(26px); | ||
| -ms-transform: translateX(26px); | ||
| transform: translateX(26px); | ||
| } | ||
|
|
||
| /* Rounded sliders */ | ||
| .slider.round { | ||
| border-radius: 34px; | ||
| } | ||
|
|
||
| .slider.round:before { | ||
| border-radius: 50%; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Es importante cambiar var por let o const (la mayoría pide const aunque no hay gran diferencia entre let y const es un debate) pero var compromete tu código, ya no lo uses.