Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] [core] Chi Blast: fix xi.ability.adjustDamage param fix, rename xi.ability.adjustDamage params, add safety to UpdateEnmityFromDamage #7091

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Apparently Chi Blast was adding the mob to it's own enmity list from damage instead of the player. This fixes that and adds safety so that can't happen again

Steps to test these changes

Chi Blast a mob, see !exec print(tostring(target:getEnmityList())) doesnt contain the mob itself

@zach2good zach2good merged commit f8695cc into LandSandBoat:base Feb 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants