Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Replace ts::task_system with asio::thread_pool #7104

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Core: Replace ts::task_system with asio::thread_pool #7104

merged 3 commits into from
Feb 20, 2025

Conversation

zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Introduces a very basic "wait" for all queue'd tasks to finish. The previous task_system only did that on destruct.

@zach2good zach2good force-pushed the remove_task_system branch 2 times, most recently from 1db80bf to e759d45 Compare February 20, 2025 21:05
@zach2good zach2good merged commit 91b8103 into base Feb 20, 2025
13 checks passed
@zach2good zach2good deleted the remove_task_system branch February 20, 2025 22:17
@UmeboshiXI UmeboshiXI mentioned this pull request Feb 23, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WinterSolstice8 WinterSolstice8 WinterSolstice8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zach2good @WinterSolstice8