symbols charged and payment metadata check #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
reviewed
Dec 19, 2024
api/clients/v2/accountant.go
Outdated
| if overflowBinRecord.Usage == 0 && relativeBinRecord.Usage-numSymbols < binLimit && numSymbols <= binLimit { | ||
| overflowBinRecord.Usage += relativeBinRecord.Usage - binLimit | ||
| overflowBinRecord.Usage += relativeBinRecord.Usage - binLimit | ||
| if overflowBinRecord.Usage == relativeBinRecord.Usage-binLimit && relativeBinRecord.Usage-symbolUsage < binLimit && symbolUsage <= binLimit { |
There was a problem hiding this comment.
not sure if i understand this change, it seems like this condition is same as before but we preemptively add the overflow usage before the check.
why was this change necessary?
There was a problem hiding this comment.
Yep, we added this so that we will always add to the bin if reservation is used, otherwise both current and overflow bin gets reverted when the accountant uses ondemand (rollback added for overflow at line)
ian-shim
approved these changes
Dec 19, 2024
hopeyen
force-pushed
the
hope/payments-fix
branch
from
810bbcb to
08d61fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Making sure that symbols charged are correctly tracked, and payment metadata is considered valid if one of the payment specification is missing
Checks