feat: add SemVerMixin
#1034
Merged
feat: add SemVerMixin
#1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
approved these changes
Jan 21, 2025
ypatil12
requested changes
Jan 21, 2025
Removed, wondering if pods & token should also use |
ypatil12
approved these changes
Jan 21, 2025
0xClandestine
added a commit
that referenced
this pull request
Jan 21, 2025
0xClandestine
added a commit
that referenced
this pull request
Jan 22, 2025
refactor: review changes refactor: review changes feat: remaining semver feat: remaining semver refactor: review changes refactor: review changes fix: ci refactor: remove make cmd fix: ci fix: ci feat: add `SemVerMixin` (#1034) * feat: add `SemVerMixin` * refactor: add `_majorVersion` helper for `SignatureUtils` * test: passing * test: passing * refactor: rename EIP712_VERSION * refactor: review changes chore: forge fmt refactor: natspec improvements chore: forge fmt fix: eip712 typehash refactor: remove version overrides refactor: remove make bump-version refactor: immutable version refactor: remove unused import chore: `make bump-version VERSION=1` refactor: `SignatureUtils` -> `SignatureUtilsMixin` fix: bump-version.sh chore: `make bump-version VERSION=1.0.3` feat: add `make bump-version` feat: add version fn refactor: cleanup fix: signature utils
0xClandestine
added a commit
that referenced
this pull request
Jan 29, 2025
refactor: review changes refactor: review changes feat: remaining semver feat: remaining semver refactor: review changes refactor: review changes fix: ci refactor: remove make cmd fix: ci fix: ci feat: add `SemVerMixin` (#1034) * feat: add `SemVerMixin` * refactor: add `_majorVersion` helper for `SignatureUtils` * test: passing * test: passing * refactor: rename EIP712_VERSION * refactor: review changes chore: forge fmt refactor: natspec improvements chore: forge fmt fix: eip712 typehash refactor: remove version overrides refactor: remove make bump-version refactor: immutable version refactor: remove unused import chore: `make bump-version VERSION=1` refactor: `SignatureUtils` -> `SignatureUtilsMixin` fix: bump-version.sh chore: `make bump-version VERSION=1.0.3` feat: add `make bump-version` feat: add version fn refactor: cleanup fix: signature utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional extension of #1015.