forked from carpentries/sandpaper
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting up Python through renv #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provision references.md to fix Glossary 404; Maintainer QOL improvements
allow references file to be included in dropdown
Update DESCRIPTION
This will fix carpentries#415
…rting Update cache reporting
bump version to dev
there was an issue with numbered list
update function name in the text to match code block
…2023-03 update workflows to give explicit permissions
fix block anchors
This will address carpentries#463
…te-headings-463 add headings to instructor notes summary
…ing-445 Only process standalone images into figures
bump version; add news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to create new lessons with Python support added using
create_lesson(..., add_python = TRUE)
. The Python environment is controlled by renv and the existing sandpaper functions such asmanage_deps()
will take Python dependencies into account.Also adds two helper functions:
use_python()
sets up Python environment in existing lessonpy_install("<package>")
installs Python packages in the correct environment and records them in"requirements.txt"
Closes #12
See also carpentries#448
Current known problems
sandpaper::update_cache()
does not play nicely yet with this implementation; when a Python package is recorded inrequirements.txt
but not installed, callingupdate_cache()
will not install the Python dependency and overwrite therequirements.txt
file, removing the dependency.