Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y333/milestone1 redux #32

Merged
merged 27 commits into from
Sep 26, 2024
Merged

Y333/milestone1 redux #32

merged 27 commits into from
Sep 26, 2024

Conversation

yogh333
Copy link
Collaborator

@yogh333 yogh333 commented Sep 16, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@yogh333
Support Tx v1
ac22e5b
@yogh333
Re-enable signHash() function
2544052
@yogh333
Update Ragger tests: read apdus from data file
0507d0e
@yogh333
Update Ragger: tx V1 clear and blind signing
81ac479
@yogh333
Update Ragger: sign hash
8eb6e5b
@yogh333
Test sign Hash OK
e45e02a
@yogh333
Fix Pedersen hash for v1 Tx
9043b19
@yogh333
Fix shifting hash function
ec040cf
@yogh333
Update tools
bf8f70f
@yogh333
Ragger tests OK
faa4c90
@yogh333
Update CI: build check-signature binary
da98a27
@yogh333
Update CI: fix typo
f11fe4e
@yogh333
Update CI: fix typo again
6666e36
@yogh333
Run clippy
2ed4fb8
@yogh333
Make check-binary executable if needed
4571585
@yogh333
Make difference in between signing a hash and signing a Tx hash
e9d6082
@yogh333
ÃÃUpdate Rust SDK and use proper TransactionType
0eb5b06
@yogh333
Use last Rust SDK
15f4353
@yogh333
Update HomeAndSettings
9c9096f
@yogh333
Use new NBGL HomeAndSettings
9e76145
@yogh333
Use display()
ebd5c30
@yogh333
Use last Rust SDK
4248780
@yogh333
Fix clippy issue
d4a72ea
@yogh333
Merge pull request #33 from LedgerHQ/y333/starknet_nbgl2
cdd2699 
Y333/starknet nbgl2
@socket-security Socket Security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: pypi/[email protected]

View full report↗︎

bboilot-ledger
bboilot-ledger requested changes Sep 24, 2024
View reviewed changes
Copy link

@bboilot-ledger bboilot-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yogh333 👋
Looks overall good to me expect a potential issue on the pedersen implementation.

starknet/src/crypto/pedersen.rs Show resolved Hide resolved
starknet/src/crypto/pedersen.rs Show resolved Hide resolved
starknet/src/main.rs Outdated Show resolved Hide resolved
bboilot-ledger
bboilot-ledger previously approved these changes Sep 25, 2024
View reviewed changes
@yogh333 yogh333 merged commit 0e4dce5 into develop Sep 26, 2024
36 checks passed
@yogh333 yogh333 deleted the y333/milestone1_redux branch September 26, 2024 08:07
This was referenced Sep 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboilot-ledger bboilot-ledger bboilot-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogh333 @bboilot-ledger