Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y333/milestone1 redux #32

Merged
merged 27 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ac22e5b
Support Tx v1
yogh333 Sep 11, 2024
2544052
Re-enable signHash() function
yogh333 Sep 12, 2024
0507d0e
Update Ragger tests: read apdus from data file
yogh333 Sep 12, 2024
81ac479
Update Ragger: tx V1 clear and blind signing
yogh333 Sep 12, 2024
8eb6e5b
Update Ragger: sign hash
yogh333 Sep 12, 2024
e45e02a
Test sign Hash OK
yogh333 Sep 12, 2024
9043b19
Fix Pedersen hash for v1 Tx
yogh333 Sep 13, 2024
ec040cf
Fix shifting hash function
yogh333 Sep 16, 2024
bf8f70f
Update tools
yogh333 Sep 16, 2024
faa4c90
Ragger tests OK
yogh333 Sep 16, 2024
da98a27
Update CI: build check-signature binary
yogh333 Sep 16, 2024
f11fe4e
Update CI: fix typo
yogh333 Sep 16, 2024
6666e36
Update CI: fix typo again
yogh333 Sep 16, 2024
2ed4fb8
Run clippy
yogh333 Sep 16, 2024
4571585
Make check-binary executable if needed
yogh333 Sep 16, 2024
e9d6082
Make difference in between signing a hash and signing a Tx hash
yogh333 Sep 17, 2024
0eb5b06
ÃÃUpdate Rust SDK and use proper TransactionType
yogh333 Sep 18, 2024
15f4353
Use last Rust SDK
yogh333 Sep 18, 2024
9c9096f
Update HomeAndSettings
yogh333 Sep 19, 2024
9e76145
Use new NBGL HomeAndSettings
yogh333 Sep 20, 2024
ebd5c30
Use display()
yogh333 Sep 20, 2024
4248780
Use last Rust SDK
yogh333 Sep 23, 2024
d4a72ea
Fix clippy issue
yogh333 Sep 23, 2024
cdd2699
Merge pull request #33 from LedgerHQ/y333/starknet_nbgl2
yogh333 Sep 23, 2024
c3bd1cc
Update after Donjon review
yogh333 Sep 24, 2024
bd982f5
Update doc (APDU protocol)
yogh333 Sep 26, 2024
eeba855
Use last Rust SDK and delete traces
yogh333 Sep 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 20 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,29 @@ jobs:
upload_app_binaries_artifact: "compiled_app_binaries"
builder: ledger-app-builder

build_check_signature:
name: Build binary used to check signture during the test
runs-on: ubuntu-latest
container:
image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools:latest
steps:
- name: Clone
uses: actions/checkout@v4
- name: Build
run: |
cargo build -p check-signature
- name: Upload app binary
uses: actions/upload-artifact@v4
with:
name: check-signature
path: target/debug/check-signature
if-no-files-found: error

ragger_tests:
name: Run ragger tests using the reusable workflow
needs: build_application
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
with:
download_app_binaries_artifact: "compiled_app_binaries"
additional_app_binaries_artifact: "check-signature"
additional_app_binaries_artifact_dir: "target/debug"
Loading
Loading