bugfix: celo transfers content being passed to the device #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Wozacosta
commented
Jan 8, 2025
| @@ -118,6 +118,7 @@ const buildTransaction = async (account: CeloAccount, transaction: Transaction) | |||
|
|
|||
| celoTransaction = { | |||
| ...celoTransaction, | |||
| value: value.toFixed(), | |||
There was a problem hiding this comment.
broadcast fails when setting value here:
Transaction has been reverted by the EVM:
{
"blockHash": "0xe74a3082ed28fd566e7171335ec751b939b3e240bdff9a27a69f4ea677f21f42",
"blockNumber": 29731228,
"contractAddress": null,
"cumulativeGasUsed": 5769523,
"effectiveGasPrice": 10000000000,
"from": "0x849af8f177065ab056ed7bef4e473f5e7a6cee90",
"gasUsed": 27078,
"logs": [],
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"status": false,
"to": "0x471ece3750da237f93b8e339c536989b8978a438",
"transactionHash": "0x7822bba8331a92a9b6584fd908bd06a6b401395b726661df4aa8c1f5ee0477f9",
"transactionIndex": 43,
"type": "0x0"
}
Wozacosta
commented
Jan 8, 2025
| @@ -112,12 +112,14 @@ const buildTransaction = async (account: CeloAccount, transaction: Transaction) | |||
| from: account.freshAddress, | |||
| to: celoToken.address, | |||
| data: celoToken.transfer(transaction.recipient, value.toFixed()).txo.encodeABI(), | |||
| // value: `0x${value.toString(16)}`, // NOTE: this breaks at the estimateGas just below | |||
There was a problem hiding this comment.
setting value here (be it as value: value.toFixed or as an hex string, fails at the gas estimation (const gas = await kit.connection.estimateGasWithInflationFactor(celoTransaction);)
There was a problem hiding this comment.
it looks like its sending CELO via an erc20 transfer. (ie data is populated) but a simple native transfer is cheaper and probably all thats needed.
There was a problem hiding this comment.
Any idea why this had to be done? Commit message of the code i've replaced mentions Use erc20 for Celo token to fix precision issues. Maybe this went around a legacy behaviour
|
A clue might lie in how celo cli craft their transaction: |
Wozacosta
changed the title
ComradeAERGO
reviewed
Jan 9, 2025
qperrot
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
Before (transfer to 0x1D5F344C7d5E7C3Fea434989B928fAb21B263246)
After
❓ Context
🧐 Checklist for the PR Reviewers