Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: celo transfers content being passed to the device #8840

Merged
merged 5 commits into from
Jan 9, 2025
Merged

bugfix: celo transfers content being passed to the device #8840

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bcdf0b
wip: fix display, break broadcast
Wozacosta Jan 8, 2025
ecb93c8
note on value breaking gas estimation
Wozacosta Jan 8, 2025
e4441ff
sending creates a simple transaction object
Wozacosta Jan 8, 2025
9edcc23
changeset
Wozacosta Jan 8, 2025
58f686a
missing from field
Wozacosta Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libs/ledger-live-common/src/families/celo/buildTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,14 @@ const buildTransaction = async (account: CeloAccount, transaction: Transaction)
from: account.freshAddress,
Wozacosta marked this conversation as resolved.
Show resolved Hide resolved
to: celoToken.address,
data: celoToken.transfer(transaction.recipient, value.toFixed()).txo.encodeABI(),
// value: `0x${value.toString(16)}`, // NOTE: this breaks at the estimateGas just below
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting value here (be it as value: value.toFixed or as an hex string, fails at the gas estimation (const gas = await kit.connection.estimateGasWithInflationFactor(celoTransaction);)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like its sending CELO via an erc20 transfer. (ie data is populated) but a simple native transfer is cheaper and probably all thats needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this had to be done? Commit message of the code i've replaced mentions Use erc20 for Celo token to fix precision issues. Maybe this went around a legacy behaviour

};

const gas = await kit.connection.estimateGasWithInflationFactor(celoTransaction);

celoTransaction = {
...celoTransaction,
value: value.toFixed(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broadcast fails when setting value here:

Shottr 2025-01-08 10 43 12 
Transaction has been reverted by the EVM:
{
  "blockHash": "0xe74a3082ed28fd566e7171335ec751b939b3e240bdff9a27a69f4ea677f21f42",
  "blockNumber": 29731228,
  "contractAddress": null,
  "cumulativeGasUsed": 5769523,
  "effectiveGasPrice": 10000000000,
  "from": "0x849af8f177065ab056ed7bef4e473f5e7a6cee90",
  "gasUsed": 27078,
  "logs": [],
  "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  "status": false,
  "to": "0x471ece3750da237f93b8e339c536989b8978a438",
  "transactionHash": "0x7822bba8331a92a9b6584fd908bd06a6b401395b726661df4aa8c1f5ee0477f9",
  "transactionIndex": 43,
  "type": "0x0"
}

gas,
};
}
Expand Down
Loading