Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coin:xrp): add memo and destination tag in crafting #9076

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(coin:xrp): add memo and destination tag in crafting #9076

wants to merge 3 commits into from

Conversation

jprudent
Copy link
Contributor

@jprudent jprudent commented Jan 31, 2025 •
edited
Loading

integration tests: https://github.com/LedgerHQ/ledger-live/actions/runs/13076078720
(failing but I think I'm not accountable)

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:42pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:42pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:42pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:42pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated cli labels Jan 31, 2025
@jprudent jprudent changed the base branch from main to develop January 31, 2025 15:12
@jprudent jprudent changed the title back 8291 xrp add memo feat(coin:xrp): add memo and destination tag in crafting Jan 31, 2025
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated cli labels Jan 31, 2025
@jprudent jprudent force-pushed the back-8291_xrp_add_memo branch from 1090f1b to abdf44c Compare January 31, 2025 15:31
@jprudent jprudent marked this pull request as ready for review January 31, 2025 15:35
@jprudent jprudent requested a review from a team as a code owner January 31, 2025 15:35
@jprudent jprudent force-pushed the back-8291_xrp_add_memo branch from abdf44c to 20231ab Compare February 3, 2025 17:13
@jprudent jprudent force-pushed the back-8291_xrp_add_memo branch from 4666d95 to 8ed2cd3 Compare February 4, 2025 17:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

[Bot] Testing with 'Nitrogen' ✅ 1 txs ($111.32) ⏲ 41s

✅ 1 specs are successful: XRP

What is the bot and how does it work? Everything is documented here!

Details of the 1 mutations

Spec XRP (5)

Spec XRP found 5 XRP accounts. Will use XRP 2.4.2 on nanoS 2.1.0
undefined: 1.08088 XRP (200ops) (r9etPtq3oboweMPju5gdYufmvwhH2euz8z on 44'/144'/0'/0/0) #0 js:2:ripple:r9etPtq3oboweMPju5gdYufmvwhH2euz8z:
undefined: 1.10653 XRP (200ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH:
undefined: 2.95945 XRP (200ops) (rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn on 44'/144'/2'/0/0) #2 js:2:ripple:rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn:
undefined: 38.8558 XRP (41ops) (rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC on 44'/144'/3'/0/0) #3 js:2:ripple:rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC:
undefined: 0 XRP (0ops) (rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu on 44'/144'/4'/0/0) #4 js:2:ripple:rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu:
necessary accounts resynced in 0.21ms
▬ XRP 2.4.2 on nanoS 2.1.0
→ FROM undefined: 1.10653 XRP (200ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH: (! sum of ops -9.012271 XRP)
max spendable ~0.106527
★ using mutation 'move ~50%'
→ TO undefined: 2.95945 XRP (200ops) (rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn on 44'/144'/2'/0/0) #2 js:2:ripple:rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn:
✔️ transaction 
SEND 0.053888 XRP
TO rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn
with fee=0.00001 XRP
  tag=123
STATUS (2012ms)
  amount: 0.053888 XRP
  estimated fees: 0.00001 XRP
  total spent: 0.053898 XRP
errors: 
warnings: 
✔️ has been signed! (3.8s) 
✔️ broadcasted! (166ms) optimistic operation: 
  -0.053888 XRP      OUT        8823854FA1B2CC58C815FDE7D6CE9BC114EAA0CA7362A56D8FD8E83EB69D8277 2025-02-05T10:30
✔️ operation confirmed (11.2s): 
  -0.053898 XRP      OUT        8823854FA1B2CC58C815FDE7D6CE9BC114EAA0CA7362A56D8FD8E83EB69D8277 2025-02-05T10:30
✔️ undefined: 1.05263 XRP (201ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH: (! sum of ops -9.066169 XRP)(in 11.2s)
✔️ destination operation 
  +0.053888 XRP      IN         8823854FA1B2CC58C815FDE7D6CE9BC114EAA0CA7362A56D8FD8E83EB69D8277 2025-02-05T10:30
(in 11.2s)
Portfolio ($111.32) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
XRP (5) 643 ops (+2), 40.0027 XRP ($111.32) 💪 999+ r9etPtq3oboweMPju5gdYufmvwhH2euz8z 
undefined: 1.08088 XRP (200ops) (r9etPtq3oboweMPju5gdYufmvwhH2euz8z on 44'/144'/0'/0/0) #0 js:2:ripple:r9etPtq3oboweMPju5gdYufmvwhH2euz8z:
undefined: 1.05263 XRP (201ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH:
undefined: 3.01334 XRP (201ops) (rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn on 44'/144'/2'/0/0) #2 js:2:ripple:rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn:
undefined: 38.8558 XRP (41ops) (rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC on 44'/144'/3'/0/0) #3 js:2:ripple:rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC:
undefined: 0 XRP (0ops) (rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu on 44'/144'/4'/0/0) #4 js:2:ripple:rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu:
Performance ⏲ 41s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 0.77ms 7.1s 0.90ms 2012ms 3.8s 166ms 11.2s 11.2s
XRP (4) 0.77ms 7.1s 0.90ms 2012ms 3.8s 166ms 11.2s 11.2s

What is the bot and how does it work? Everything is documented here!

sprohaszka-ledger
sprohaszka-ledger reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have keep dedicated field into a separate substructure.

libs/coin-framework/src/api/types.ts Show resolved Hide resolved
@hedi-edelbloute hedi-edelbloute added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@hedi-edelbloute hedi-edelbloute added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@hedi-edelbloute hedi-edelbloute added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnicoulaud-ledger jnicoulaud-ledger jnicoulaud-ledger left review comments

@sprohaszka-ledger sprohaszka-ledger sprohaszka-ledger left review comments

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

Assignees

@jprudent jprudent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jprudent @hedi-edelbloute @jnicoulaud-ledger @sprohaszka-ledger