Issue #38: decouple drupal download from drupal install #49
Conversation
| # Create database and install Drupal. | ||
| mysql -e "create database $DRUPAL_TI_DB" | ||
|
|
||
| cd drupal |
There was a problem hiding this comment.
This should be:
cd "$DRUPAL_TI_DRUPAL_BASE"
|
I have not had a chance to work on this lately. Sorry. |
|
Hello @mradcliffe and @LionsAd, I have had a chance to look at this however the first thing I did was rebase issue-38 on master which needed some merge conflicts solving, so I am not sure what the best way to contribute to this PR is. I can create a PR into mradcliffe:issue-38 but that will be messy to review, so I have also created a PR from yanniboi:issue-38 to yanniboi:master (matching LionsAd:master) on my fork which makes the overall review and testing easier (maybe...) here: yanniboi#1 What I have mainly done is, rather than changing the behat and simpletest runners to use a different function to install drupal, I have made it so 'drupal_ti_ensure_drupal' still downloads and installs drupal, but it downloads drupal by calling another re-entrant function 'drupal_ti_ensure_drupal_download' which can be called by phpunit-core rather than 'drupal_ti_ensure_drupal'. This means no changes are needed to behat and simpletest. Let me know what the best way to get this into the current PR is or if it is easier to create a new PR? |
|
I have spoken to @mradcliffe on IRC and he is happy for me to start a new PR from my fork. Will post a link to the new PR here. |
|
Closing in favor of other pull request. |
I might as well open this for review so that I can make changes or figure out what tests are needed.
I just rebased, but for some reason had to force push to my remote.