Add placeholder gears as logo #120
Conversation
|
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-06-23 17:11:17 UTC |
Added some docs explaining to edit the logo, and also updated MDAKits placeholder to this. |
This reverts commit 909b821.
|
@orbeckst is this what you were thinking? I could also drop the question mark in the placeholder if that's simpler! |
There was a problem hiding this comment.
Looking great. I’d leave the template with question mark in, just as you have it.
Once you’re done with the logo here, can you also add the official MDAkit logo to the branding repo?
(I’m not 100% sure if we should put the empty template into branding as well — it might become confusing. Perhaps have a separate repo for free templates???)
tests/test_options.py
Outdated
| @@ -39,8 +39,8 @@ def test_official_mda_theme(self, tmpdir): | |||
|
|
|||
| text = conf.read_text() | |||
| assert '"mda_official": True,' in text | |||
| assert "html_logo" not in text | |||
| assert "html_favicon" not in text | |||
| # assert "html_logo" not in text | |||
There was a problem hiding this comment.
maybe worth removing these if they are no longer useful?
Adds the logo to MDAKits
Changes made in this Pull Request:
PR Checklist