lib.util.Namespace raises the expected exception #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib.util.Namespace` allows to query a namespace by index or by
attribute. It allows to use both the following syntaxes to access the
same element:
ns = lib.util.Namespace()
ns['key'] = 'plop'
ns['key'] # Access by index
ns.key # Access by attribute
The class is used to permit some flexibility when accessing auxiliary
data attached to trajectories.
Prior to this commit, accessing a non-existing item from a namespace by
attribute would raise a KeyError while an AttributeError should be
raise. This breaks functions that test the features of an object by
looking for some attributes, and are therefore capturing AttributeError
as a sign the attribute is missing.
In particular, raising the wrong exception confused
`numpy.lib.type_check.iscomplexobj` in numpy 1.12.0. This confusion lead
to `assert_equal` to miss behave in that version of numpy, therefore
breaking the tests for MDAnalysis when upgrading from python 1.11.3 to
1.12.0.
This commit makes sure that the expected exception is raised when
accessing an non-existing item by attribute in a Namespace object.
| @@ -91,6 +91,8 @@ Fixes | |||
| * Fixed selections using operators backwards ('prop 10 > mass') and sensitivity | |||
| about whitespace around these (PR #1156 Issue #1011 #1009) | |||
| * Fixed PSA analysis is now using AlignTraj | |||
| * The namespace used for auxiliary data now raises an AttributeError instead | |||
There was a problem hiding this comment.
Wasn't NameSpace new in 0.16? If so, we don't have to document any fixes to it, (because CHANGELOG is for release to relrease changes)
There was a problem hiding this comment.
Indeed. I always forget what gets introduced when.
Added tests for lib.util.Namespace Moved test_util to lib/test_util
Added tests for lib.util.Namespace Moved test_util to lib/test_util
|
@richardjgowers is this OK for you? |
richardjgowers
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.util.Namespaceallows to query a namespace by index or byattribute. It allows to use both the following syntaxes to access the
same element:
The class is used to permit some flexibility when accessing auxiliary
data attached to trajectories.
Prior to this commit, accessing a non-existing item from a namespace by
attribute would raise a KeyError while an AttributeError should be
raise. This breaks functions that test the features of an object by
looking for some attributes, and are therefore capturing AttributeError
as a sign the attribute is missing.
In particular, raising the wrong exception confused
numpy.lib.type_check.iscomplexobjin numpy 1.12.0. This confusion leadto
assert_equalto miss behave in that version of numpy, thereforebreaking the tests for MDAnalysis when upgrading from python 1.11.3 to
1.12.0.
This commit makes sure that the expected exception is raised when
accessing an non-existing item by attribute in a Namespace object.
Adresses part of #1166
PR Checklist
[ ] Docs?