Fix trz endian #1427
Merged
Fix trz endian #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@rathann please check that you're happy with this. |
|
To the merge master: Be careful when merging so that @rathann remains the author; I think this requires a simple merge commit instead any of the rebase variants. You might also want to merge #1426 first into develop and then resolve a merge commit in CHANGELOG (because I had to create the new 0.17.0 section here, too). |
- Numpy dtype int (iN) and float (fN) specifiers assume native-endian by default, so force them to be little-endian. - Closes #1424. - added CHANGELOG entry and docs
kain88-de
force-pushed
the
fix-trz-endian
branch
from
88ce2fd
to
3f58740
Compare
|
I'm trying to squeeze this into 0.16.2 |
|
@kain88-de I'd be pretty amazed if someone else was using this format, I think we can put it into 17.0 instead |
|
OK |
richardjgowers
approved these changes
Jun 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1424
Replaces PR #1425
Changes made in this Pull Request:
PR Checklist