-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAMF - NNUnet Lung and Nodules #78
Conversation
@LennyN95 we could use your advise on this model. We run two different nnunet models, then combine the output niftis into one nifti, then convert to dicom-seg.
|
Hi @vanossj, Sure, that is possible! So, the module config is the general configuration for all usages of that module. However, that can be overwritten directly from within the execution chain: execute:
- module: NNUnetRunner
nnunet_task: Task003_Liver
roi: LIVER,LIVER+NEOPLASM_MALIGNANT_PRIMARY
- module: NNUnetRunner
nnunet_task: Task007_Pancreas
roi: PANCREAS,PANCREAS+NEOPLASM_MALIGNANT_PRIMARY
modules:
NNUnetRunner:
nnunet_model: 3d_lowres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid file overwrites, the @IO.Output
decorator has an auto_increment
option:
https://github.com/MHubAI/mhubio/blob/main/mhubio/core/IO.py#L325
That is correct. I will take care of this and release a new base image including this and some additional minor fixes.
So you need |
Yes, that is the sct code we used |
Added You can now use |
The default of the These changes are available in our latest base image |
I tried to run testing with the |
I also added |
sample:
idc_version: "Data Release 4.0 May 29, 2020"
data:
- SeriesInstanceUID: 1.3.6.1.4.1.14519.5.2.1.7777.9002.290917407640793598352855735724
aws_url: s3://idc-open-data/b925cf2a-de89-426d-b300-27b136264555/*
path: input_data
reference:
url: https://drive.google.com/file/d/1la5-sFlaWGopGiBvTdi-_V375nc59e9h/view?usp=sharing |
Archive.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean implementation! I added a few questions and minor remarks. Thank you!
|
||
DataOrganizer: | ||
targets: | ||
- dicomseg-->[i:sid]/bamf_nnunet_ct_lung.seg.dcm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that bamf_nnunet_ct_lungnodules
would be a better fit for a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated with this naming convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx! This would require to change the folder name (modles/$model_name
) too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the model directory to bamf_nnunet_ct_lungnodules
@LennyN95 Let me know if you need other changes. |
/test sample:
idc_version: "Data Release 4.0 May 29, 2020"
data:
- SeriesInstanceUID: 1.3.6.1.4.1.14519.5.2.1.7777.9002.290917407640793598352855735724
aws_url: s3://idc-open-data/b925cf2a-de89-426d-b300-27b136264555/*
path: input_data
reference:
url: https://drive.google.com/file/d/1pTqmrrQWC4qHO8z4d72FPVAczh-Zj7hq |
/review @LennyN95 all review comments have been fixed |
NOTE: New model version already available in #92. |
No description provided.