Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable transcript search #408

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Reenable transcript search #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26dc627
Reenable transcript search
DanOlson Aug 31, 2024
5fc0346
Merge pull request #399 from Minitex/reenable-transcript-search
swandog30 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/advanced_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def index
###
# Temporarily excluded from advanced search. Remove
# next line to re-enable the transcript search input
field.include_in_advanced_search = false
# field.include_in_advanced_search = false
field.solr_parameters = { :'spellcheck.dictionary' => 'default' }
field.solr_local_parameters = {
qf: '$transcription_qf',
Expand Down
16 changes: 8 additions & 8 deletions app/controllers/catalog_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,14 +454,14 @@ def parse_referrer_pagination_params(query_string)
# when the advanced search form is submitted.
#
# Commenting out transcript until we have a good plan for transcript search results - PKS
#config.add_search_field('transcript') do |field|
# field.include_in_simple_search = false
# field.solr_parameters = { :'spellcheck.dictionary' => 'default' }
# field.solr_local_parameters = {
# qf: '$transcription_qf',
# pf: '$transcription_pf'
# }
#end
config.add_search_field('transcript') do |field|
field.include_in_simple_search = false
field.solr_parameters = { :'spellcheck.dictionary' => 'default' }
field.solr_local_parameters = {
qf: '$transcription_qf',
pf: '$transcription_pf'
}
end
config.add_search_field('description') do |field|
field.include_in_simple_search = false
field.solr_parameters = { :'spellcheck.dictionary' => 'default' }
Expand Down
3 changes: 1 addition & 2 deletions spec/features/advanced_search_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
solr_fixtures('sll:22470', 'otter:297', 'msn:2277', 'msn:2670', 'msn:2680')
end

xit 'can find a record by text contained in its transcript' do
pending 'Transcript is temporarily excluded from advanced search'
it 'can find a record by text contained in its transcript' do
visit '/'
click_link 'Advanced Search'
fill_in 'Transcript', with: '"fifty percent cut"'
Expand Down
Loading