Fix UV iframe embed scenario #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we migrated UV to the CDN, we stopped serving UV assets from /public, which ended up breaking the iframe use case. This revives it by routing to a controller and rendering a view template. We're using a route & view rather than a static file in /public because we want to initialize UV with the same config options in both places which we can do with a partial. Additionally, if we were to serve the config as a url via a query parameter on the iframe src, UV ends up loading the attribution pop up before the config loads, which is not the exerience we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated UV to the CDN, we stopped serving UV assets from /public, which ended up breaking the iframe use case. This revives it by routing to a controller and rendering a view template. We're using a route & view rather than a static file in /public because we want to initialize UV with the same config options in both places which we can do with a partial. Additionally, if we were to serve the config as a url via a query parameter on the iframe src, UV ends up loading the attribution pop up before the config loads, which is not the exerience we want.