Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): correctly convert file: URL to path #131

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(github): correctly convert file: URL to path #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca4c3b1
fix(github): correctly convert `file:` URL to path
aduh95 Oct 22, 2024
5897be8
Apply suggestions from code review
MoLow Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/github/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const path = require('node:path');
const { fileURLToPath } = require('node:url');
const util = require('node:util');
const { EOL } = require('node:os');
const core = require('@actions/core');
Expand All @@ -12,11 +13,14 @@ const stack = new StackUtils({ cwd: WORKSPACE, internals: StackUtils.nodeInterna

const isFile = (name) => name?.startsWith(WORKSPACE);

const getRelativeFilePath = (name) => (isFile(name) ? path.relative(WORKSPACE, require.resolve(name) ?? '') : null);
const getRelativeFilePath = (name) => (isFile(name) ? path.relative(WORKSPACE, name) : null);

function getFilePath(fileName) {
if (fileName.startsWith('file://')) {
return getRelativeFilePath(new URL(fileName).pathname);
return getRelativeFilePath(fileURLToPath(fileName));
}
if (!path.isAbsolute(fileName)) {
return getRelativeFilePath(path.resolve(fileName) ?? '');
}
return getRelativeFilePath(fileName);
}
Expand Down
Loading