-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export names of client secrets must be unique, add aws_region to client secrets in secrets manager #27
Conversation
@@ -369,14 +373,15 @@ def add_service_client( | |||
"client_secret": self._get_client_secret(client), | |||
"userpool_id": self.userpool.user_pool_id, | |||
"scope": " ".join(scope.scope_name for scope in scopes), | |||
"aws_region": region, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
Note The client id of the dev stack did change (the user pool and users were persisted). I manually tested the dev ingest api by updating the client id in the console and, after testing, I updated the client id in the The dev auth stack has not been redeployed for over a year and the client id change may not be related to this change BUT to be safe I have opened another PR to make sure we don't impact the veda-auth-stack-uah client ID which would have multiple downstream impacts. This PR will create a new veda-auth-staging stack so that we don't have to worry about cycling possible client id changes to veda-stac-ingestor. |
fix(ci): use dedicated staging environment config in ci
What
The Outputs section contains duplicate Export names
by making client secret id export names unique (and more specific). New export names are:{stack_name}-workflows-client-secret-id
for the service client secret used by airflow{stack_name}-programmatic-client-secret-id
for the use password token generating client used for endpoints that grant tokens (ingest-api, maybe workflows-api in future){stack_name}-identity-provider-secret-id
for the optional data managers group (not used in higher environments)aws_region
to each stored client secretveda-auth-stack-staging
How tested
Testing under way in dev stack. I will confirm
aws_region
is included and correct in secrets manager secrets for clientsManual administrative steps needed after merge to main
VEDA_CLIENT_ID
with the programmatic client id generated for the new veda-auth-stack-stagingveda-stac-ingestor-*
andveda-auth-stack-uah
). Step one in planning how we will sunset these.