Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landcover 2001-2020 #134

Merged
merged 7 commits into from
Nov 18, 2022
Merged

Add landcover 2001-2020 #134

merged 7 commits into from
Nov 18, 2022

Conversation

vlulla
Copy link
Contributor

@vlulla vlulla commented Nov 10, 2022

Related: NASA-IMPACT/veda-data-pipelines#226

  • Needs legend class names and/or color preferences
  • Any specific image for cover?

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 271a5f6
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6377c4ec49945a00098e0a47
😎 Deploy Preview https://deploy-preview-134--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vlulla vlulla requested review from ividito and anayeaye November 11, 2022 14:55
@vlulla
Copy link
Contributor Author

vlulla commented Nov 11, 2022

I'm not sure why the deploy preview link does not work. The local yarn seems to work for me.

@vlulla vlulla changed the title Feature/add landcover 2001 2020 Add landcover 2001-2020 Nov 14, 2022
@vlulla
Copy link
Contributor Author

vlulla commented Nov 14, 2022

Setting the "single_datetime": "2020-01-01T00:00:00Z" instead of "datetime_range": "year" in https://github.com/NASA-IMPACT/veda-data-pipelines/blob/cafdec337a20c51b2242422bce84b7c6f1ceb03e/data/step_function_inputs/bangladesh-landcover-2001-2020.json#L17 seems to have fixed the netlify preview link.

Colors based on recommendation listed in discussion
at NASA-IMPACT/veda-data-pipelines#226
@j08lue
Copy link
Contributor

j08lue commented Nov 17, 2022

Nice things are coming together! 🚀

I can see we still have an issue that the classes are not rendered nicely at overview level, only when you zoom in to full data resolution:
image

But I guess you will publish now anyways and raise a QA issue for later?

@vlulla
Copy link
Contributor Author

vlulla commented Nov 17, 2022

@j08lue you are correct! It is unclear to us (me, @moradology, and @ividito), even after multiple discussions and pairing sessions, what is the underlying cause of these rendering issues. It appears that there is something about these tifs that is not playing nicely with the titiler but we are unable to pinpoint what exactly that is!

I don't know what is involved with publishing this but I will try to get it done tomorrow.

Copy link
Member

@slesaad slesaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vlulla
Copy link
Contributor Author

vlulla commented Nov 18, 2022

So what do I do next?

@slesaad
Copy link
Member

slesaad commented Nov 18, 2022

@vlulla merge the PR and you should be done! 🎉

it should appear in https://visex.netlify.app/ once it's merged (might take a minute tho)

@vlulla vlulla merged commit 051e635 into develop Nov 18, 2022
@vlulla vlulla deleted the feature/add-landcover-2001-2020 branch November 18, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants