Review updates #723
Triggered via pull request
September 13, 2023 18:59
danielfdsilva
Status
Success
Total duration
1m 26s
Artifacts
–
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
14 warnings
|
prep
The following actions uses node12 which is deprecated and will be forced to run on node16: styfle/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
ts-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint:
app/scripts/components/analysis/define/aoi-selector.tsx#L99
React Hook useCallback has a missing dependency: 'mapRef'. Either include it or remove the dependency array
|
|
lint:
app/scripts/components/analysis/define/aoi-selector.tsx#L118
React Hook useEffect has a missing dependency: 'mapRef'. Either include it or remove the dependency array
|
|
lint:
app/scripts/components/analysis/define/index.tsx#L105
Use a ! assertion to more succinctly remove null and undefined from the type
|
|
lint:
app/scripts/components/analysis/define/index.tsx#L115
Use a ! assertion to more succinctly remove null and undefined from the type
|
|
lint:
app/scripts/components/analysis/define/index.tsx#L170
Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator
|
|
lint:
app/scripts/components/analysis/define/index.tsx#L196
Unnecessary optional chain on a non-nullish value
|
|
lint:
app/scripts/components/analysis/define/index.tsx#L203
React Hook useEffect has a missing dependency: 'datasetsLayers'. Either include it or remove the dependency array
|
|
lint:
app/scripts/components/analysis/define/use-custom-aoi.ts#L129
Unnecessary conditional, value is always falsy
|
|
lint:
app/scripts/components/analysis/page-hero-media.tsx#L143
React Hook useEffect has a missing dependency: 'theme.color'. Either include it or remove the dependency array
|
|
lint:
app/scripts/components/analysis/page-hero-media.tsx#L159
Unexpected any. Specify a different type
|