Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEA-3713 #52

Merged
merged 61 commits into from
Jan 29, 2024
Merged

AEA-3713 #52

merged 61 commits into from
Jan 29, 2024

Conversation

seansteberisal
Copy link
Collaborator

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Details

add support for additional environments and the ability to run tests against a internal-dev pr in the EPS API

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the jira ticket has been updated with the github pull request link

@natasafrgk
adds url variable defaults to blank
c68ab1a
@natasafrgk
adds pr id in yaml
9142280
@natasafrgk
changes env value
214959a
@natasafrgk
edits request_ping
d148166
@natasafrgk
changes environment variables
fed9f1f
@natasafrgk
removes logging for pr id
9d21759
@natasafrgk
creates def to handle pr id suffix
68005b4
@natasafrgk
creates condition for the env in workflow
37a2096
@natasafrgk
creates condition for the env in workflow
83d8e5c
@natasafrgk
creates condition for the env in workflow
0d740cd
@natasafrgk
creates condition for the env in workflow
6984853
@natasafrgk
creates condition for the env in workflow
a8a1d0c
@natasafrgk
creates condition for the env in workflow
e9b0c6f
@natasafrgk
creates condition for the env in workflow after environment
42a8d21
@natasafrgk
creates condition for the env in workflow after environment with assi…
5797fb8 
…gnment
@natasafrgk
creates condition for the env in workflow in reg test step with assig…
98f3795 
…nment
@natasafrgk
removes changes
876c3fc
@natasafrgk
removes changes in envrionment py
c144cea
@natasafrgk
reverts deletion
cc56f6a
@natasafrgk
Merge remote-tracking branch 'origin' into AEA-3713
9dfca7a
@natasafrgk
tries again with tennary op
e31b95c
@natasafrgk
tries again with tennary op and hardcoded default
baf8b85
@natasafrgk
tries again with tennary op with if before environment
8db30e7
@natasafrgk
tries with separate if
e902a50
@natasafrgk
adds condition to before all
0ebbe28
@natasafrgk
adds condition back into job
d3368d4
@natasafrgk
adds extra step to evaluate inputs
aa2f640
@natasafrgk
edits step
e40b636
@natasafrgk
edits step
e6b3ea9
@natasafrgk
edits step
84d56ca
seansteberisal and others added 21 commits January 24, 2024 12:37
@seansteberisal
added "env" to before all from context userdata
2b05f80 
updated poetry.lock
@natasafrgk
removes mention of base url
e6c7341
@natasafrgk
removes safe net for baseurl
c4644da
@natasafrgk
changes dict method
279c39a
@natasafrgk
convert to behave cmd line for env
5d3b76d
@natasafrgk
changes dict method
05d94ce
@seansteberisal
not using .env file anymore
fee7330 
hard-coded base urls into environment.py
@seansteberisal
reworked if logic for internal-dev pr branches
99c2354 
moved EPS product name into constant
@seansteberisal
pre-commit jobs run
d5c97ce 
comments deleted
@seansteberisal
renamed DEV_BASE_URL to INTERNAL_DEV_BASE_URL
c1d0267
@seansteberisal
added print to see which URL the ping request is going to
950f396
@seansteberisal
Merge branch 'main' into AEA-3713
aa49998 
# Conflicts:
#	poetry.lock
@seansteberisal
poetry.lock
6ea4484
@seansteberisal
remove poetry-dotenv-plugin
0d6b074
@seansteberisal
added more base urls
529c1ca
@seansteberisal
changed _ to - in baseURL constant names
26c2a11
@seansteberisal
Added a couple of comments to remind us to change the way we handle U…
593d59d 
…RLs when we come to include support for additional products
@seansteberisal
black formatting
5c992fa
@seansteberisal
append pr- only if pr- wasn't already provided
6874ca6
@seansteberisal
Merge branch 'main' into AEA-3713
0504643 
# Conflicts:
#	features/environment.py
@seansteberisal
fixed merge conflict
0249e06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

This branch is work on a ticket in the NHS England AEA JIRA Project. Here's a handy link to the ticket:

AEA-3713

@seansteberisal seansteberisal merged commit 8a1b955 into main Jan 29, 2024
10 checks passed
@seansteberisal seansteberisal deleted the AEA-3713 branch January 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-nhs anthony-nhs anthony-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seansteberisal @anthony-nhs @apm-ops @natasafrgk